Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require data.spec only on certain data types #366

Merged
merged 6 commits into from
Sep 8, 2023
Merged

Require data.spec only on certain data types #366

merged 6 commits into from
Sep 8, 2023

Conversation

adnejacobsen
Copy link
Contributor

@adnejacobsen adnejacobsen commented Sep 7, 2023 •
edited
Loading

This schema change makes data.spec required only when class is one of [table, surface].

Related to #365

@adnejacobsen adnejacobsen marked this pull request as draft September 7, 2023 07:34
@adnejacobsen adnejacobsen linked an issue Sep 7, 2023 that may be closed by this pull request
Required property "spec" is not present in dictionary metadata #365
Closed
@adnejacobsen adnejacobsen marked this pull request as ready for review September 7, 2023 07:45
perolavsvendsen
perolavsvendsen approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@perolavsvendsen perolavsvendsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤷‍♀️

This leaves us slightly out of synch with the non-merged 0.9.0 schema. So we may have to retrofit this into that.

@adnejacobsen adnejacobsen merged commit 7d2a709 into main Sep 8, 2023
7 checks passed
@adnejacobsen adnejacobsen deleted the spec-conditional-require branch September 8, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perolavsvendsen perolavsvendsen perolavsvendsen approved these changes

@jcrivenaes jcrivenaes Awaiting requested review from jcrivenaes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Required property "spec" is not present in dictionary metadata
2 participants
@adnejacobsen @perolavsvendsen